Open
Conversation
rozza
force-pushed
the
JAVA-6125
branch
4 times, most recently
from
8c4a620 to
bdd2356
Compare
Test Scala 3 on Java 8 JAVA-6125
Member
Author
rozza
commented
Mar 17, 2026
| package org.mongodb.scala.unified | ||
|
|
||
| object ClientEncryptionTest extends UnifiedTest { | ||
| class ClientEncryptionTest extends UnifiedTest { |
Member
Author
There was a problem hiding this comment.
Had to change so the data method is no longer static.
| override def createClientEncryption( | ||
| keyVaultClient: JMongoClient, | ||
| clientEncryptionSettings: JClientEncryptionSettings | ||
| ): JClientEncryption = { |
Member
Author
There was a problem hiding this comment.
spotless automatic changes
| junit-bom = { module = "org.junit:junit-bom", version.ref = "junit-bom" } | ||
| junit-jupiter = { module = "org.junit.jupiter:junit-jupiter" } | ||
| junit-jupiter-params = { module = "org.junit.jupiter:junit-jupiter-params" } | ||
| junit-jupiter-platform-launcher = { module = "org.junit.platform:junit-platform-launcher" } |
Member
Author
There was a problem hiding this comment.
The platform launcher was needed to be explicit - otherwise the knockon effect was kotlin tests failing due to junit version disparities
vbabanin
reviewed
Mar 19, 2026
| .filter(parameterResolver -> parameterResolver.getClass().getName().contains("ParameterizedTestParameterResolver")) | ||
| .filter(parameterResolver -> { | ||
| String name = parameterResolver.getClass().getName(); | ||
| // JUnit 5.10: ParameterizedTestParameterResolver |
Member
There was a problem hiding this comment.
Do we still need the JUnit 5.10 configuration? It looks like all modules now depend on 5.14.
P.S. I kicked off a build without the ParameterizedTestParameterResolver check and didn’t see any failures related to the resolver: patch
Member
Author
There was a problem hiding this comment.
I removed and have updated the error message as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Scala 3 on Java 8
JAVA-6125