Do various small timeout-related improvements#1908
Merged
stIncMale merged 1 commit intomongodb:mainfrom Mar 16, 2026
Merged
Conversation
rozza
reviewed
Mar 11, 2026
rozza
approved these changes
Mar 11, 2026
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
One question about readability - but not a blocker.
LGTM
stIncMale
commented
Mar 12, 2026
Member
Author
stIncMale
left a comment
stIncMale
left a comment
There was a problem hiding this comment.
I originally left some comments for reviewers, but forgot to submit them... Submitting them now.
| import com.mongodb.lang.Nullable; | ||
|
|
||
| /** | ||
| * An exception indicating that the driver has timed out waiting for either a server or a connection to become available. |
Member
Author
There was a problem hiding this comment.
This description became incorrect when MongoOperationTimeoutException was introduced.
|
|
||
| /** | ||
| * Exception indicating that the execution of the current operation timed out as a result of the maximum operation time being exceeded. | ||
| * Exception indicating that the execution of the current command timed out by the server |
Member
Author
There was a problem hiding this comment.
Note the "operation" -> "command" change.
Member
Author
There was a problem hiding this comment.
The changes in this file were caused by #1899 (comment).
Member
|
LGTM! - Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.