PYTHON-5162 [pymongocrypt] Bundle libmongocrypt 1.13.0 and PYTHON-5221 Support $lookup in CSFLE and QE #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested changes
Mar 19, 2025
| new_lines.append(")") | ||
| new_lines.append(line) | ||
| skip = False | ||
| with target.open("w") as f: |
Co-authored-by: Steven Silvester <steve.silvester@mongodb.com>
Member
|
Could you open a new PYTHON ticket to track the $lookup changes here and link it in the title? |
blink1073
approved these changes
Mar 19, 2025
Member
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
LGTM! You can merge once all of the python* tasks pass.
sleepyStick
changed the title
sleepyStick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-5162
and
https://jira.mongodb.org/browse/PYTHON-5221
Additionally, I implemented the pymongocrypt part of PYTHON-5046 here
Also changed the binding script because I didn't think it was working properly? But if it was working as intended initially, I can undo those changes.