MONGOCRYPT-865 replace sprintf with safer alternatives#1127
Merged
kevinAlbs merged 6 commits intomongodb:masterfrom Feb 13, 2026
Merged
MONGOCRYPT-865 replace sprintf with safer alternatives#1127kevinAlbs merged 6 commits intomongodb:masterfrom
sprintf with safer alternatives#1127kevinAlbs merged 6 commits intomongodb:masterfrom
Conversation
The return value does not include the NULL byte. To ensure no truncation occurs, the return value must be strictly less than the buffer size.
rcsanchez97
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace calls of
sprintfwith the safersnprintf.snprintfaccepts a capacity to ensure bytes are not written beyond the capacity.sprintfis replaced with calls tobson_snprintfin libmongocrypt for portability and consistency.bson_snprintfalways NULL terminates.snprintfmay not always NULL terminate (see Remarks on MSVC docs). Since kms-message does not depend on libbson,snprintfis used in kms-message, and the NULL terminator is added manually where needed.Return values of
snprintfandbson_snprintfare checked. fb53369 fixes an existing return value check.