fix: bump diagramming lib COMPASS-9935#7643
Closed
paula-stacho wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @mongodb-js/diagramming package from version 2.2.1 to 2.3.0, which changes how edge field information is passed to the diagramming library. The update simplifies the codebase by removing the need to calculate field indices and instead directly passing field IDs.
- Removed helper functions for finding nodes and field indices that are no longer needed
- Updated
relationshipToDiagramEdgeto pass field IDs directly instead of calculated indices - Simplified function signatures and dependency arrays by removing the
nodesparameter
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-data-modeling/src/utils/nodes-and-edges.ts | Removed helper functions and updated relationshipToDiagramEdge to use field IDs instead of indices |
| packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts | Updated tests to match new function signature and verify field ID mapping |
| packages/compass-data-modeling/src/store/analysis-process.ts | Removed nodes parameter from relationshipToDiagramEdge call |
| packages/compass-data-modeling/src/components/diagram-editor.tsx | Removed nodes parameter and dependency from relationshipToDiagramEdge usage |
| packages/compass-components/package.json | Bumped @mongodb-js/diagramming to version 2.3.0 |
Collaborator
Author
|
I messed up the callbacks and due to lack of tests in the diagramming lib I only noticed it here 🙈 |
ac51f68 to
59e45c9
Compare
This was referenced Dec 18, 2025
lerouxb
approved these changes
Dec 30, 2025
1ad9fab to
c3116af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumping the diagramming package - this includes a change in the way the edge fields are passed which actually simplifies the code here.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes