Make minimum channel reserve configurable #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable min_their_channel_reserve_satoshis field to ChannelHandshakeConfig, allowing users to set the minimum channel reserve value. Special case: When set to 0, the dust limit check is bypassed. This enables LSP use cases where clients are able to fully withdraw their funds from the channel without closing it. For non-zero values below the dust limit, validation still enforces the dust limit. Replaces hardcoded MIN_THEIR_CHAN_RESERVE_SATOSHIS constant with configurable value while maintaining backward compatibility. Default remains 1000 sats to preserve existing behavior.
| announce_for_forwarding: false, | ||
| commit_upfront_shutdown_pubkey: true, | ||
| their_channel_reserve_proportional_millionths: 10_000, | ||
| min_their_channel_reserve_satoshis: 1_000, |
There was a problem hiding this comment.
probably use MIN_THEIR_CHAN_RESERVE_SATOSHIS?
Author
There was a problem hiding this comment.
This change basically deprecates that constant as it's no longer a real constant. Although I should double check if that constant is actually exposed publicly and remove it if not.
|
min_their_channel_reserve_satoshis should only be set to 0 on channels between lsp-client, so I guess this will need to be set not as a general config but as a ChannelHandshakeConfig, so min_their_channel_reserve_satoshis needs to be added to ChannelHandshakeConfigUpdate and then to the ChannelHandshakeConfig::apply |
amackillop
force-pushed
the
austin/mdk-189/configurable-min-channel-reserve
branch
from
a8f686d to
52603a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configurable
min_their_channel_reserve_satoshisfield toChannelHandshakeConfig, allowing users to set the minimum channel reserve value.Special case: When set to 0, the dust limit check is bypassed. This enables LSP use cases where clients are able to fully withdraw their funds from the channel without closing it. For non-zero values below the dust limit, validation still enforces the dust limit.
Replaces hardcoded
MIN_THEIR_CHAN_RESERVE_SATOSHISconstant with configurable value while maintaining backward compatibility. Default remains 1000 sats to preserve existing behavior.Discussion
I went with a configurable amount here but in the end I am left wondering if just a boolean to remove the reserve is better especially given the special handling of the zero case. Is the flexibility to set whatever one wants really needed? For us we just want it to be zero.
Also just found this related issue which notes some specs for this