Handle absolute paths in Link active check#555
Open
vpzomtrrfrt wants to merge 1 commit intomolefrog:v3from
Open
Handle absolute paths in Link active check#555vpzomtrrfrt wants to merge 1 commit intomolefrog:v3from
vpzomtrrfrt wants to merge 1 commit intomolefrog:v3from
Conversation
|
|
Owner
|
@vpzomtrrfrt This look like a breaking change to me, would you mind providing a bit more context on the PR? |
Author
|
Yeah I guess it technically might be? I assumed the existing behaviour was a bug, since it made Links not be marked as active even though they were to the current path |
|
I came across the same issue, the Link component does not set the active class if you provide absolute path. Here is simple demo reproducing the issue - https://codesandbox.io/p/sandbox/wv6gvv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.