Use magic instead of make and port to mojo 25.3.0.dev2025032205 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a magic mojo project and migrated the Makefile and README to use it.
Collaborator
|
Hey thanks for making the PR! I've enabled github actions on this PR but it looks like it's failing |
Collaborator
|
It looks like the github actions file needs to be updated |
Change the github workflow to use magic both for running the test and the pre-commit.
Collaborator
|
Thanks for the contribution! I'm sa-code on the discord server, feel free to DM me if you like |
Contributor
Author
|
Thanks for accepting my PR :) I am not sure where the discord server is? |
Collaborator
|
Ah on Modular's discord server. I also added you on linkedin (hopefully) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 commits. The first one replaces make with magic. The second one makes the code compile and tests pass with nightly mojo.
The major mojo changes are:
mutinstead ofinout