feat(metro): add metro-plugin-rock and migrate examples to Rock#4652
Open
jbroma wants to merge 16 commits intomodule-federation:mainfrom
Open
feat(metro): add metro-plugin-rock and migrate examples to Rock#4652jbroma wants to merge 16 commits intomodule-federation:mainfrom
jbroma wants to merge 16 commits intomodule-federation:mainfrom
Conversation
RNEF has been renamed to Rock (ROCKjs). This adds a new @module-federation/metro-plugin-rock package targeting @rock-js/tools and @rock-js/config, while keeping metro-plugin-rnef published for backward compatibility with a deprecation notice.
Migrate all three metro example apps (host, mini, nested-mini) from @rnef/* packages to @rock-js/* (v0.13.0). Update native build files, e2e scripts, and CI workflow to use Rock tooling and actions v3.
🦋 Changeset detectedLatest commit: 150ea0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jbroma
changed the title
jbroma
changed the title
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report11 package(s) changed, 30 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.32 MB (+8.5 kB (+0.1%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
The 'github-actions' shorthand for remoteCacheProvider emits a deprecation warning with ANSI codes that corrupts $GITHUB_ENV inside the Rock CI actions, breaking both Android and iOS e2e jobs.
Fork callstackincubator/{android,ios}@V3 into .github/actions/ with
working-directory propagated to all composite steps. The upstream
actions miss it on cache-related steps, causing rock.config.mjs
lookup failures when the app is not at the repo root.
Also switch rock.config.mjs to use providerGitHub() (non-deprecated)
from @rock-js/provider-github and add NO_COLOR=1 to e2e jobs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdea246de4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…irectory fix Remove local action forks and reference upstream PRs: - callstackincubator/android#25 - callstackincubator/ios#27
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e6ad09eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pin callstackincubator/android to 599c4a7 (PR module-federation#25) and callstackincubator/ios to a5f0126 (PR module-federation#27) which propagate working-directory to all composite steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RNEF was renamed to Rock by Callstack. This PR adds
@module-federation/metro-plugin-rockas the new primary package, deprecatesmetro-plugin-rnef, and migrates all metro example apps, CI, and docs to use Rock tooling.Changes
New package —
metro-plugin-rock@rock-js/*(v0.13.0) androckCLIDeprecation —
metro-plugin-rnefExample app migration
metro-example-host,metro-example-mini,metro-example-nested-minimigrated from@rnef/*to@rock-js/*rock.config.mjsusesproviderGitHub()from@rock-js/provider-github(non-deprecated remote cache API)CI
e2e-metro.yml: bumpedcallstackincubator/{android,ios}from@v1to latest@v3NO_COLOR=1env var to e2e jobsrun-metro-e2e.mjsscript (rnef → rock references)Docs
Related Issue
RNEF → Rock rename by Callstack (npm scope
@rnef/*→@rock-js/*, CLIrnef→rock)Types of changes
Checklist