Alias add improvements #3343
Open
Alias add improvements #3343
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinbndr
commented
Jun 9, 2024
martinbndr
commented
- Fixes an issue with error message being incorrect.
- Protects eval command for being added into an alias if the user does not have permissions to it as Owner level etc. as the command is quite dangerous and should not be added by normal moderators (Could be used to nuke server for example).
- Fixes an issue with error message being incorrect. - Protects eval command for being added into an alias if the user does not have permissions to it as Owner level etc. as the command is quite dangerous and should not be added by normal moderators (Could be used to nuke server for example).
StephenDaDev
requested review from
a team,
Zinoviya99,
lorenzo132 and
sebkuip
sebkuip
requested changes
Dec 13, 2025
Member
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
There's an issue that you forgot to check causing errors.
| embed = utils.create_not_found_embed(name, self.bot.aliases.keys(), "Alias") | ||
| return await ctx.send(embed=embed) | ||
|
|
||
| embed = await self.make_alias(name, value, "Edited") |
Member
There was a problem hiding this comment.
This call to make_alias does not have the new ctx arg which would break editing aliases
Contributor
Author
Ih damn yea seems I forgot that, will fix it in next few days when I have time. |
StephenDaDev
dismissed
their stale review
Needs changes. Will re-review after changes are made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.