Feat/add gemma4 support#199
Open
EvineR666 wants to merge 4 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Gemma4 models by adding a new template and a cookbook example for multimodal FSDP2 training. It also refactors the base template's pipeline execution to use method names for better compatibility. Feedback includes fixing a copy-paste error in the evaluation dataset mapping, moving general multimodal processing logic to the base template, and improving code quality through consistent logging, removal of unused imports, and the addition of a training progress bar.
tpx818
reviewed
May 21, 2026
Collaborator
|
请在readme中补充gemma4的支持 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
This PR mainly contains two changes:
Experiment results
Paste your experiment result here(if needed).