Skip to content

fix: sync ModelCapabilities schema with Go struct and docs #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remo-lab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sync ModelCapabilities schema with Go struct and docs #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion schema/config-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,19 @@
},
"toolUsage": {
"type": "boolean"
},
"reward": {
"type": "boolean"
},
"languages": {
"type": "array",
"items": {
"type": "string",
"pattern": "^[a-z]{2}$"
}
}
}
},
"additionalProperties": false
},
"Modality": {
"type": "string",
Expand Down
103 changes: 103 additions & 0 deletions schema/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,109 @@ func TestConfig(t *testing.T) {
]
}
}
`,
fail: true,
},
// expected failure: reward is not boolean
{
config: `
{
"descriptor": {
"name": "xyz-3-8B-Instruct",
"version": "3.1"
},
"config": {
"paramSize": "8b",
"capabilities": {
"inputTypes": ["text"],
"outputTypes": ["text"],
"reward": "true"
}
},
"modelfs": {
"type": "layers",
"diffIds": [
"sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
]
}
}
`,
fail: true,
},
// expected failure: languages is not an array
{
config: `
{
"descriptor": {
"name": "xyz-3-8B-Instruct",
"version": "3.1"
},
"config": {
"paramSize": "8b",
"capabilities": {
"inputTypes": ["text"],
"outputTypes": ["text"],
"languages": "en"
}
},
"modelfs": {
"type": "layers",
"diffIds": [
"sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
]
}
}
`,
fail: true,
},
// expected failure: language code is not a two-letter ISO 639 code
{
config: `
{
"descriptor": {
"name": "xyz-3-8B-Instruct",
"version": "3.1"
},
"config": {
"paramSize": "8b",
"capabilities": {
"inputTypes": ["text"],
"outputTypes": ["text"],
"languages": ["fra"]
}
},
"modelfs": {
"type": "layers",
"diffIds": [
"sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
]
}
}
`,
fail: true,
},
// expected failure: unknown field in capabilities
{
config: `
{
"descriptor": {
"name": "xyz-3-8B-Instruct",
"version": "3.1"
},
"config": {
"paramSize": "8b",
"capabilities": {
"inputTypes": ["text"],
"unknownField": true
}
},
"modelfs": {
"type": "layers",
"diffIds": [
"sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
]
}
}
`,
fail: true,
},
Expand Down
Loading