Conversation
Summary of ChangesHello @chlins, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant dependency migration, moving the project's reliance from a deprecated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the import paths from github.com/dragonflyoss/model-spec/specs-go/v1 to github.com/modelpack/model-spec/specs-go/v1 and updates the annotation key as described. The changes are mostly mechanical but well-executed. I've identified one area in pkg/backend/attach.go where the code can be refactored to improve maintainability by reducing duplication. My suggestion is to adopt a more data-driven approach for selecting processors.
1758d73 to
d79e7b4
Compare
Signed-off-by: chlins <chlins.zhang@gmail.com>
d79e7b4 to
83bef26
Compare
This pull request updates the codebase to use the new
github.com/modelpack/model-spec/specs-go/v1import path instead of the deprecatedgithub.com/dragonflyoss/model-spec/specs-go/v1, and updates related code references accordingly. It also updates a constant annotation key to reflect the correct organization.Closes #317
Dependency and import updates:
github.com/dragonflyoss/model-spec/specs-go/v1withgithub.com/modelpack/model-spec/specs-go/v1throughout the codebase and tests to use the new canonical model spec package. [1] [2] [3] [4] [5] [6] [7] [8] [9]Code and constant updates:
legacymodelspectypes and constants inpkg/backend/attach.goto usemodelspecequivalents, ensuring consistency with the new import. [1] [2] [3]annotationModelfileconstant from"org.cnai.modctl.modelfile"to"org.cncf.modctl.modelfile"inpkg/backend/build.goto reflect the correct organization namespace.