Add more robust base64 check#786
Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom Jul 21, 2025
Merged
Conversation
…obResourceContent. * This fixes an issue found in the servers repo with this PR: modelcontextprotocol/servers#2382 * Under the hood, z.string().base64() uses a regular expression to validate the string. * While this regex is fine for typical inputs, running it against a string that is several megabytes long can cause the JavaScript engine's regex parser to hit its internal recursion limit, resulting in a "Maximum call stack size exceeded" error.
This was referenced Jul 19, 2025
chenxi-null
pushed a commit
to chenxi-null/typescript-sdk
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a more robust base64 check for AudioContent, ImageContent and BlobResourceContent. This fixes an issue discovered while creating this PR in the servers repo: modelcontextprotocol/servers#2382
Motivation and Context
The problem and the fix
z.string().base64()uses a regular expression to validate the string.z.string().base64()with a newBase64SchemaHow Has This Been Tested?
In the Inspector CLI and UI, tested the large file that was causing the "Maximum call stack size exceeded" error. It is no longer present and the 4mb file can be processed.
Inspector CLI
Inspector UI
Breaking Changes
Types of changes
Checklist
Additional context