fix: Ensure completions capability is registered on setCompletionRequestHandler call#546
Merged
ihrpr merged 3 commits intomodelcontextprotocol:mainfrom Jun 10, 2025
Conversation
…e with completion or prompt completable argument registration
9 tasks
fredericbarthelet
changed the title
9 tasks
Contributor
Author
|
Hey @ihrpr, sorry for the ping. Any chance this will be merged sometime? It's blocking on another issue on the inspector. |
ihrpr
approved these changes
Jun 10, 2025
Contributor
ihrpr
left a comment
ihrpr
left a comment
There was a problem hiding this comment.
Sorry about the delay! LGTM
| mcpServer.server.connect(serverTransport), | ||
| ]); | ||
|
|
||
| expect(client.getServerCapabilities()).toMatchObject({ completions: {} }) |
Contributor
There was a problem hiding this comment.
should we also check that prompts are there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advertising support for
completionsin servers where acompletionRequestHandlerhas been defined - meaning, when at least one resource or one prompt has been registered.Just like:
registerCapabilitiesis called to addtoolssupport onsetToolRequestHandlerscallregisterCapabilitiesis called to addresourcessupport onsetResourceRequestHandlerscallregisterCapabilitiesis called to addpromptssupport onsetPromptRequestHandlerscallthis PR calls
registerCapabilitiesto turncompletionssupport on wheneversetCompletionRequestHandleris calledMotivation and Context
While implementing modelcontextprotocol/inspector#441, I found out that the only way to advertise completions support was defining it manually in Server constructor argument.
How Has This Been Tested?
I've tested this both with an application with a ResourceTemplate and a prompt with
completableargument. Added unit tests as well.Breaking Changes
None
Types of changes
Checklist
Additional context