Skip to content

fix: return 404 instead of 400 for invalid session IDs in examples #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kai-agent-free wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −12
Open

fix: return 404 instead of 400 for invalid session IDs in examples #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/server/src/elicitationFormExample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ async function main() {
const mcpGetHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand All @@ -415,7 +415,7 @@ async function main() {
const mcpDeleteHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/server/src/elicitationUrlExample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ app.post('/mcp', authMiddleware, mcpPostHandler);
const mcpGetHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down Expand Up @@ -683,7 +683,7 @@ app.get('/mcp', authMiddleware, mcpGetHandler);
const mcpDeleteHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/server/src/simpleStreamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ if (useOAuth && authMiddleware) {
const mcpGetHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down Expand Up @@ -757,7 +757,7 @@ if (useOAuth && authMiddleware) {
const mcpDeleteHandler = async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/server/src/simpleTaskInteractive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ app.post('/mcp', async (req: Request, res: Response) => {
app.get('/mcp', async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand All @@ -708,7 +708,7 @@ app.get('/mcp', async (req: Request, res: Response) => {
app.delete('/mcp', async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/server/src/standaloneSseWithGetStreamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ app.post('/mcp', async (req: Request, res: Response) => {
app.get('/mcp', async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;
if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
6 changes: 3 additions & 3 deletions test/conformance/src/everythingServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ app.post('/mcp', async (req: Request, res: Response) => {
await transport.handleRequest(req, res, req.body);
return;
} else {
res.status(400).json({
res.status(404).json({
jsonrpc: '2.0',
error: {
code: -32_000,
Expand Down Expand Up @@ -958,7 +958,7 @@ app.get('/mcp', async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;

if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand All @@ -985,7 +985,7 @@ app.delete('/mcp', async (req: Request, res: Response) => {
const sessionId = req.headers['mcp-session-id'] as string | undefined;

if (!sessionId || !transports[sessionId]) {
res.status(400).send('Invalid or missing session ID');
res.status(404).send('Invalid or missing session ID');
return;
}

Expand Down
Loading