fix: call onerror for nested catch blocks in handlePostRequest#1677
Open
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: call onerror for nested catch blocks in handlePostRequest#1677kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
kai-agent-free wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
In handlePostRequest, two nested try/catch blocks (JSON parsing and JSON-RPC schema validation) were creating error responses via createJsonErrorResponse but not calling this.onerror, silently swallowing the errors. The outer catch correctly called this.onerror. Add this.onerror?.(error as Error) calls to both nested catches, consistent with the pattern used elsewhere in the codebase. Add tests verifying onerror is called for both error cases. Fixes modelcontextprotocol#1395
🦋 Changeset detectedLatest commit: 49d2573 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1395
In
handlePostRequest, two nested try/catch blocks were silently swallowing errors:req.json()) — returnedcreateJsonErrorResponse(400, -32_700, 'Parse error: Invalid JSON')without callingthis.onerrorJSONRPCMessageSchema.parse) — returnedcreateJsonErrorResponse(400, -32_700, 'Parse error: Invalid JSON-RPC message')without callingthis.onerrorThe outer catch at the end of
handlePostRequestcorrectly callsthis.onerror?.(error as Error), but these nested catches did not, making it impossible for consumers to observe these error conditions.Changes
this.onerror?.(error as Error)to both nested catch blocks, consistent with the pattern used in the outer catch and in other methods (e.g.,replayEvents,validateRequestHeaders)onerroris called for invalid JSON and invalid JSON-RPC messagesTesting
All existing tests pass plus 2 new tests (39 total in server package).