Fix abort signal listener leak in _requestWithSchema#1672
Open
lucaalbinati wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix abort signal listener leak in _requestWithSchema#1672lucaalbinati wants to merge 1 commit intomodelcontextprotocol:mainfrom
lucaalbinati wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The abort listener added to the caller's signal was never removed, causing listeners to accumulate across requests sharing the same signal. Named the listener, added explicit removeEventListener on all exit paths, and added once:true as a defensive fallback.
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignalin_requestWithSchemawas never removed, causing listeners to accumulate across requests sharing the same signalremoveEventListeneron all exit paths (response handler, cancel, timeout, transport send failure, task enqueue failure), and addedonce: trueas a defensive fallbackTest plan