fix: prevent command injection in example URL opening (v1.x backport)#1579
Merged
felixweinberger merged 1 commit intov1.xfrom Feb 24, 2026
Merged
fix: prevent command injection in example URL opening (v1.x backport)#1579felixweinberger merged 1 commit intov1.xfrom
felixweinberger merged 1 commit intov1.xfrom
Conversation
|
commit: |
felixweinberger
approved these changes
Feb 24, 2026
Contributor
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks for doing this! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1553 to v1.x.
Removes the use of
exec()with string interpolation to open URLs inelicitationUrlExample.tsandsimpleOAuthClient.ts, which allowed command injection via crafted URLs.Rather than adding the
opennpm package (as #1553 does onmain), this takes a simpler approach: remove the auto-open behavior entirely and print the URL for the user to open manually. On v1.x there is no separate examples package, so addingopenwould introduce a new runtime dependency on the published SDK. Since the examples already handle waiting via HTTP callbacks and MCP notifications (not the browser process), this change has no effect on functionality.AI Disclaimer