Conversation
🦋 Changeset detectedLatest commit: 2c60294 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Enforce session isolation in
InMemoryTaskStoreProblem
The
InMemoryTaskStoreaccepted asessionIdparameter on every method but silently ignored it. This allowed any authenticated client to enumerate all task IDs viatasks/listand read or mutate tasks belonging to other sessions — violating theTaskStorecontract which explicitly statessessionIdbinds operations to a specific session.Root Cause
Every method parameter was prefixed with
_sessionId(unused), and the session was never persisted alongside the stored task.listTasksiterated all task IDs globally without filtering.Fix
sessionIdon theStoredTaskrecord at creation time.getStoredTask(taskId, sessionId)helper that enforces ownership: when both the caller and the stored task have asessionId, they must match — otherwise the task is treated as not found.getTask,storeTaskResult,getTaskResult,updateTaskStatus) through this helper.listTasksby session ownership before pagination.sessionId, no filtering occurs.Tests
Added 9 regression tests covering:
sessionIdis omitted (both directions)