Skip to content

fix(core): zod schema usage for form elicitInput #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dorukozerr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(core): zod schema usage for form elicitInput #1431

dorukozerr wants to merge 1 commit into from
+8 −1

Conversation

@dorukozerr
Copy link

@dorukozerr dorukozerr commented Jan 30, 2026

Ref #1362

@dorukozerr
fix(core): zod schema usage for form elicitInput
974a61a 
- requestedSchema type definitions for form elicitInput was not
  accepting zod schemas converted into json schemas
- Not updated zod schema definition because its used for runtime
  validation
- Casted a type to get rid of TypeScript errors for converted zod
  schemas
- Autocompletions still work as discriminated union definiton for json
  schemas

Ref modelcontextprotocol#1362
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: 974a61a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 30, 2026

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1431

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1431

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1431

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1431

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1431

commit: 974a61a

@dorukozerr dorukozerr mentioned this pull request Jan 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dorukozerr