Skip to content

docs(time): fix response examples#4176

Closed
Sean-Kenneth-Doherty wants to merge 2 commits into
modelcontextprotocol:mainfrom
Sean-Kenneth-Doherty:codex/fix-time-readme-examples-verified-stale
Closed

docs(time): fix response examples#4176
Sean-Kenneth-Doherty wants to merge 2 commits into
modelcontextprotocol:mainfrom
Sean-Kenneth-Doherty:codex/fix-time-readme-examples-verified-stale

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • update the Time server README response examples to include the emitted day_of_week field
  • correct the convert_time example source/target datetimes and +14.0h offset
  • add a regression test that parses README response JSON blocks and compares them with actual TimeServer output under frozen dates

This covers the trailing-comma issue from #4142, but also fixes the stale example payloads themselves.

Validation

  • cd src/time && uv run pytest -q on current upstream main: 39 passed
  • cd src/time && uv run ruff check .
  • local merge of this fork-pushable branch with current origin/main completed without conflicts
  • cd src/time && uv run pytest -q in the local merged state: 39 passed

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Closing this draft as a duplicate of #4174. The open PR already carries the same Time README/test changes and has passing hosted checks, so keeping this draft around would just add maintainer noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant