fix(filesystem): ignore final newline in tail output#4175
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
fix(filesystem): ignore final newline in tail output#4175Sean-Kenneth-Doherty wants to merge 1 commit into
Sean-Kenneth-Doherty wants to merge 1 commit into
Conversation
Author
|
Marked ready after rechecking the patch locally. Why this is ready:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tailFileso a normal final newline is not returned as an empty trailing line.tailFilecontent instead of only checking handle cleanup.Root Cause
tailFilesplits the final chunk on\n. For text files ending in a newline,split("\n")produces a final empty sentinel, which the reverse reader counted as the last line. That maderead_text_filewithtail: 1return an empty string for ordinary POSIX-style files likeline1\nline2\nline3\n.Validation
npm exec -w src/filesystem -- vitest run __tests__/lib.test.tsnpm run build -w src/filesystem