test(fetch): add unit tests for fetch MCP server #3262
+1,120
−656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyusht-square
force-pushed
the
add-fetch-server-tests
branch
2 times, most recently
from
c7e0579 to
fc242e0
Compare
Add comprehensive test coverage for the fetch server: - TestGetRobotsTxtUrl: 6 tests for URL parsing - TestExtractContentFromHtml: 3 tests for HTML-to-markdown conversion - TestCheckMayAutonomouslyFetchUrl: 5 tests for robots.txt handling - TestFetchUrl: 6 tests for URL fetching with various scenarios Total: 20 tests covering: - URL parsing and robots.txt URL generation - HTML content extraction and markdown conversion - robots.txt permission checking (401, 403, 404, allow/disallow) - HTTP response handling (success, errors, raw mode) - Proxy support Also adds pytest and pytest-asyncio as dev dependencies.
piyusht-square
force-pushed
the
add-fetch-server-tests
branch
from
fc242e0 to
71d5d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds comprehensive unit test coverage for the
mcp-server-fetchserver, which previously had no tests.Server Details
Motivation and Context
The fetch server is one of the core reference servers but had 0% test coverage. This PR brings it in line with other servers (git, time, filesystem) that have comprehensive test suites.
How Has This Been Tested?
All 20 tests pass locally:
Tests cover:
TestGetRobotsTxtUrl: 6 tests for URL parsing (paths, ports, query params, fragments)TestExtractContentFromHtml: 3 tests for HTML-to-markdown conversion, error handlingTestCheckMayAutonomouslyFetchUrl: 5 tests for robots.txt permission checking (401/403/404/allow/disallow)TestFetchUrl: 6 tests for HTTP responses, raw mode, proxy supportBreaking Changes
None. This PR only adds tests, no changes to server behavior.
Types of changes
Checklist
Additional context
New test file:
src/fetch/tests/test_server.pyUpdated
pyproject.toml:pytestandpytest-asyncioas dev dependencies