Use width and height from launch options as the default instead of hard coded values#1670
Closed
olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Closed
Use width and height from launch options as the default instead of hard coded values#1670olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
…tead of hard coded values.
Member
Author
|
Thanks for contributing this PR. This server has been moved to the archived repository at https://github.com/modelcontextprotocol/servers-archived to reduce maintenance overhead, so we can focus our efforts on a smaller set of core servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes viewport reset issue mentioned in #1347
Description
This PR fixes an issue where the browser viewport resets to 800x600 even when custom dimensions are set in
PUPPETEER_LAUNCH_OPTIONS. It also adds documentation on what to expect when using tool params vs launch options.Server Details
Motivation and Context
The puppeteer server doesn't currently maintain viewport settings from
PUPPETEER_LAUNCH_OPTIONSacross operations. This causes inconsistent behavior where the viewport will reset to default hard-coded dimensions (800x600) even when custom dimensions are passed in the launch options.How Has This Been Tested?
Still needs more testing in the following scenarios:
Breaking Changes
None
Types of changes
Checklist