fix(rmcp-macros): use re-exported serde_json path in task_handler#735
Merged
alexhancock merged 2 commits intomodelcontextprotocol:mainfrom Mar 9, 2026
Merged
Conversation
Replace bare `::serde_json::` with `::rmcp::serde_json::` in task_handler.rs to prevent compilation errors in crates that don't directly depend on serde_json. Fixes modelcontextprotocol#487
DaleSeo
previously approved these changes
Mar 9, 2026
Member
DaleSeo
left a comment
DaleSeo
left a comment
There was a problem hiding this comment.
Thank you for this fix, @kakarot-dev!
DaleSeo
approved these changes
Mar 9, 2026
alexhancock
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
task_handlermacro generates code referencing::serde_json::directly. This causes compilation errors in crates that depend onrmcpbut don't haveserde_jsonas a direct dependency.Changed
::serde_json::to::rmcp::serde_json::incrates/rmcp-macros/src/task_handler.rsto use the re-exported path, consistent with how other generated code in the macro crate references rmcp dependencies.Fixes #487