-
Notifications
You must be signed in to change notification settings - Fork 557
Implement smoke test for clients and servers #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement smoke test for clients and servers #76
Conversation
38c3168 to
10e281e
Compare
|
Hi @jonathanhefner, could ypu please update the branch and merge all the conflicts, so that we can approve and merge it? Thanks! |
This commit adds `tests/smoke-test.sh`, which performs a smoke test of all clients and servers. The smoke test tests that the clients and servers run and that list tools is called. This commit also adds a GitHub Actions workflow to run the smoke test on all pull requests and pushes to main. For practicality, this commit modifies the TypeScript and Python clients to lazily initialize the Anthropic client, thus allowing tests to skip setting an API key. This change also provides a friendly error when users forget to set an API key. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
10e281e to
8e32f11
Compare
|
@a-akimov Thanks for the reminder! Rebased! 😃 |
|
Hi @jonathanhefner , sorry, it still shows some conflicts - please take a look. |
|
@jonathanhefner I resolved the conflict (it was a small one in package-lock.json) and approved your changes. But because I was the last one making a commit to resolve the conflict, I suppose now it needs your review and approval too. Kindly ask you to take a look to finally merge this PR as it adds a lot of value. Thank you. |
|
@jonathanhefner Could you please look into this and approve too? I believe this is a very valuable addition to this repo and would be great to merge it before we continue with merging more PRs here. |
This commit adds
tests/smoke-test.sh, which performs a smoke test of all clients and servers. The smoke test tests that the clients and servers run and that list tools is called.This commit also adds a GitHub Actions workflow to run the smoke test on all pull requests and pushes to main.
For practicality, this commit modifies the TypeScript and Python clients to lazily initialize the Anthropic client, thus allowing tests to skip setting an API key. This change also provides a friendly error when users forget to set an API key.
🤖 Generated with Claude Code