Skip to content

Auth SSE simple example#610

Merged
ihrpr merged 100 commits into
mainfrom
ihrpr/auth-example
May 7, 2025
Merged

Auth SSE simple example#610
ihrpr merged 100 commits into
mainfrom
ihrpr/auth-example

Conversation

@ihrpr

@ihrpr ihrpr commented May 1, 2025

Copy link
Copy Markdown
Contributor

Adding a simple example for auth which was implemented in #255

This tiny server is useful:

  • testing auth, will need to do the same for streamable http
  • testing inspector
  • testing clients

Tested with Inspector
image

@jerome3o-anthropic jerome3o-anthropic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look over this - and had claude look at it (here).

I think this is good for demo purposes. I'll give it a try before approving the bigger one

Base automatically changed from praboud/auth to main May 1, 2025 18:43
@ihrpr ihrpr dismissed jerome3o-anthropic’s stale review May 1, 2025 18:43

The base branch was changed.

dsp-ant
dsp-ant previously approved these changes May 2, 2025

@pcarleton pcarleton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested with the inspector, and a github app I had around, and works.

I separated out the confused deputy fix in a follow up since it's going to require some SDK changes that I don't want to block this on:
#648

@ihrpr ihrpr merged commit a027d75 into main May 7, 2025
10 checks passed
@ihrpr ihrpr deleted the ihrpr/auth-example branch May 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants