fix: fail fast when session is not started#2631
Open
Epochex wants to merge 4 commits into
Open
Conversation
2 tasks
Author
|
Follow-up for CI: Python 3.14 was still failing branch coverage due to a missing arc reported on the pytest.raises(...) context manager line in ests/client/test_resource_cleanup.py. Added # pragma: no branch there to make branch coverage stable across 3.14. Pushed commit abbbc01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ClientSession/BaseSessionis used without entering the async context manager, the receive loop never starts andinitialize()can hang indefinitely waiting for a response.This change fails fast:
send_request()andsend_notification()now raise aRuntimeErrorif the session hasn't been started viaasync with ... as session.Fixes #1452.
Tests: