feat(client): store serverInfo from initialization result#1565
Open
bjoaquinc wants to merge 6 commits intomodelcontextprotocol:mainfrom
Open
feat(client): store serverInfo from initialization result#1565bjoaquinc wants to merge 6 commits intomodelcontextprotocol:mainfrom
bjoaquinc wants to merge 6 commits intomodelcontextprotocol:mainfrom
Conversation
Author
|
Hmmm... the test failure doesnt seem related. Looks like a server failure |
maxisbey
requested changes
Nov 4, 2025
Contributor
maxisbey
left a comment
There was a problem hiding this comment.
Please add unit tests for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store server information in ClientSession._client_info after initialization when using the default client info. This allows users to access server details without manually capturing them from the InitializeResult.
Motivation and Context
Resolves #1018
How Has This Been Tested?
Created and ran a live integration test that launches a real MCP server via stdio transport. The test verifies that session._client_info is correctly updated with server info after initialization when using default client info, and that custom client_info is preserved when explicitly provided. Normal server operations (like listing tools, etc...) continue to work correctly after initialization.
Breaking Changes
None. This change only affects the internal
_client_infofield when using the default client info. Users who explicitly provide their ownclient_infowill see no behavior change. The_client_infofield is private and not part of the public API.Types of changes
Checklist
Additional context