Fixes protocol compliance gap described in issue #1419#1440
Open
ChenyangLi4288 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
Fixes protocol compliance gap described in issue #1419#1440ChenyangLi4288 wants to merge 2 commits intomodelcontextprotocol:mainfrom
ChenyangLi4288 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…l pending requester when emitting CancelledNotification (spec SHOULD-not response)
…ncellation for CancelledNotification + local requester cancellation
Author
|
any chance of getting review? @felixweinberger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
RequestResponder.mark_cancelled_without_response()to support silent cancellation.BaseSession._receive_loop()when handlingCancelledNotification.CancelledNotification, proactively cancel the local pending request sosend_request()unblocks withMcpError("Request cancelled").Motivation and Context
#1419(link).How Has This Been Tested?
tests/shared/test_session.py::test_request_cancellationto confirm the client’s in-flight request is cancelled promptly without waiting for a peer response.Breaking Changes
Types of changes
Checklist
Additional context
CancelledNotification, improving interoperability and reducing unnecessary traffic.