fix: set default to none for optional field without default value#1404
Closed
vincent0426 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix: set default to none for optional field without default value#1404vincent0426 wants to merge 1 commit intomodelcontextprotocol:mainfrom
vincent0426 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
PR attempting to resolve the same issue: #1408 |
Contributor
felixweinberger
left a comment
There was a problem hiding this comment.
Between this and #1408 if it turns out we actually need this change and not a fix to our Pydantic usage, I'd probably prefer this one for greater simplicity.
Will figure out whether this is the right approach though - there may be ways we can better use Pydantic tools rather than work around them here.
Member
|
I don't think we should add a default value if the type accepts |
Contributor
Author
|
I think pydantic treats |
Member
Yes, which is correct.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #1402
pydantic treats Optional type as required if there is no default value
output
How Has This Been Tested?
Unit tested on 5 scenarios
type | noneOptional[type]Breaking Changes
Types of changes
Checklist
Additional context