Extract BaseSession request ID increment logic#1102
Closed
ronmrdechai wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
Extract BaseSession request ID increment logic#1102ronmrdechai wants to merge 3 commits intomodelcontextprotocol:mainfrom
ronmrdechai wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
This allows the request ID increment logic to be overwritten by subclasses. I have a unique need to share sessions' underlying input and output streams, but not the sessions themselves. This would require keeping track of request IDs globally to avoid overlap. Having this logic overridable lets me do that.
Author
|
For reference, the way I've worked around this currently is that I added these two methods to a subclass of This is obviously brittle and I'd like a proper interface for it. |
Contributor
|
Hi @ronmrdechai thank you for this contribution! Apologies for the time it took to get back to this PR. The solution you have seems like the right way to handle very application specific needs - I don't think we want to take on this flexibility inside the SDK without additional motivation that this is a common request / use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title
Motivation and Context
This allows the request ID increment logic to be overwritten by
subclasses. I have a unique need to share sessions' underlying input
and output streams, but not the sessions themselves. This would require
keeping track of request IDs globally to avoid overlap.
Having this logic overridable lets me do that.
How Has This Been Tested?
CI
Breaking Changes
N/A
Types of changes
Checklist
Additional context
N/A