Be more generous with PSR versions #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference is return types. Since we dont implement these interfaces, it does not matter for us
chr-hertel
approved these changes
Dec 27, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Yup, good catch, thanks! :)
Contributor
Author
|
Thank you for merging |
Nyholm
added a commit
to symfony/ai
that referenced
this pull request
Dec 28, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [Mate] Support SF5.4 and SF6.4 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Mate is a platform/foundation. We want everyone to be able to build on top of it. By lowering the requirements to 5.4 (the lowest supported version) we allow this compatibility. Since the only dependencies are super stable components, I dont think this will make maintenance more difficult. Blocked by modelcontextprotocol/php-sdk#202 Commits ------- 54e127d [Mate] Support SF5.4 and SF6.4
symfony-splitter
pushed a commit
to symfony/ai-mate
that referenced
this pull request
Dec 28, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [Mate] Support SF5.4 and SF6.4 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Mate is a platform/foundation. We want everyone to be able to build on top of it. By lowering the requirements to 5.4 (the lowest supported version) we allow this compatibility. Since the only dependencies are super stable components, I dont think this will make maintenance more difficult. Blocked by modelcontextprotocol/php-sdk#202 Commits ------- 54e127d6 [Mate] Support SF5.4 and SF6.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference is return types. Since we dont implement these interfaces, it does not matter for us. There is no need to restrict one version or another.