fix!: Migrate Ktor extension functions from Routing to Route (#237)#531
Merged
fix!: Migrate Ktor extension functions from Routing to Route (#237)#531
Routing to Route (#237)#531Conversation
kpavlov
changed the title
Routing to Route (#237)Routing to Route (#237)
kpavlov
changed the title
Routing to Route (#237)Routing to Route (#237)
Contributor
Author
|
see #314 |
kpavlov
requested review from
devcrocod,
e5l and
tiginamaria
and removed request for
devcrocod,
e5l and
tiginamaria
…237) - Replaced `Routing` with `Route` in MCP-related functions for better composability in nested contexts. - Updated tests to verify compatibility with nested routes and subpaths. - Deprecated legacy signatures and removed redundant overloads. - Updated tests kotlin-sdk-server module
kpavlov
force-pushed
the
kpavlov/fix-routing-237
branch
from
dc3184a to
4fdf469
Compare
…nd `mcpStreamableHttp` - Introduced `path` parameter for `mcpStatelessStreamableHttp` and `mcpStreamableHttp` functions, allowing flexibility in route configuration. - Refactored integration tests to use the new path parameter. - Replaced hardcoded routes with configurable paths in Ktor server implementation.
kpavlov
force-pushed
the
kpavlov/fix-routing-237
branch
from
4fdf469 to
8405572
Compare
- Refactored `KtorRoutingExtensionsTest` to `KtorRouteExtensionsTest`. - Added validation to ensure the SSE plugin is installed before registering MCP routes. - Introduced `AbstractKtorExtensionsTest` with common utilities for MCP endpoint testing.
kpavlov
force-pushed
the
kpavlov/fix-routing-237
branch
from
8405572 to
0d3cdae
Compare
- Added usage examples for `mcpStreamableHttp` and `mcp` Ktor helpers.
kpavlov
force-pushed
the
kpavlov/fix-routing-237
branch
from
f1d18e3 to
664d56c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Ktor extension functions from
RoutingtoRoute(#237)RoutingwithRoutein MCP-related functions for better composability in nested contexts.How Has This Been Tested?
Unit test
Breaking Changes
Routing.mcp(...)extension was replaced withRoute.mcp(...)Types of changes
Checklist
Additional context
Based on #314 by @IainHull but that PR is too outdated.