test: ensure proper resource cleanup in integration tests#537
Merged
tzolov merged 1 commit intomodelcontextprotocol:mainfrom Sep 4, 2025
Merged
test: ensure proper resource cleanup in integration tests#537tzolov merged 1 commit intomodelcontextprotocol:mainfrom
tzolov merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
tzolov
commented
Sep 4, 2025
tzolov
commented
- Add try-finally blocks to guarantee server cleanup on test completion
- Call closeGracefully().block() to ensure synchronous shutdown
- Use try-with-resources for client lifecycle management where applicable
- Prevent resource leaks and potential test flakiness
- Add try-finally blocks to guarantee server cleanup on test completion - Call closeGracefully().block() to ensure synchronous shutdown - Use try-with-resources for client lifecycle management where applicable - Prevent resource leaks and potential test flakiness Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.