Revert "fix: handle the client disconnect so that the server does not crash."#464
Merged
Revert "fix: handle the client disconnect so that the server does not crash."#464
Conversation
Member
Author
|
@olaservo I merged #380 after having previously fully testing it and including videos of the problem and the fix working locally. But then I realized that I had jumped the gun. This PR works with the Here is a video of connecting to an STDIO server with that code, and the server is never crashed by a disconnecting client. Screen.Recording.2025-05-28.at.1.02.11.PM.mov |
olaservo
approved these changes
May 28, 2025
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
Revert "fix: handle the client disconnect so that the server does not crash."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #380
I realized the problem is already be fixed in the #428, and there's no need to have to refactor that one to remove most of this one's changes.