Skip to content

fix: prevent SSE transport crash on concurrent STDIO connections #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MumuTW wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −24
Open

fix: prevent SSE transport crash on concurrent STDIO connections #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 30 additions & 24 deletions server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,31 +596,34 @@ app.get(
const endpoint = `${prefix}/message`;

const webAppTransport = new SSEServerTransport(endpoint, res);
webAppTransports.set(webAppTransport.sessionId, webAppTransport);
console.log("Created client transport");

serverTransports.set(webAppTransport.sessionId, serverTransport);
console.log("Created server transport");

await webAppTransport.start();

webAppTransports.set(webAppTransport.sessionId, webAppTransport);

(serverTransport as StdioClientTransport).stderr!.on("data", (chunk) => {
if (chunk.toString().includes("MODULE_NOT_FOUND")) {
// Server command not found, remove transports
const message = "Command not found, transports removed";
webAppTransport.send({
jsonrpc: "2.0",
method: "notifications/message",
params: {
level: "emergency",
logger: "proxy",
data: {
message,
webAppTransport
.send({
jsonrpc: "2.0",
method: "notifications/message",
params: {
level: "emergency",
logger: "proxy",
data: {
message,
},
},
},
});
webAppTransport.close();
serverTransport.close();
})
.catch(() => {});
webAppTransport.close().catch(() => {});
serverTransport.close().catch(() => {});
webAppTransports.delete(webAppTransport.sessionId);
serverTransports.delete(webAppTransport.sessionId);
sessionHeaderHolders.delete(webAppTransport.sessionId);
Expand Down Expand Up @@ -658,17 +661,19 @@ app.get(
} else {
level = "info";
}
webAppTransport.send({
jsonrpc: "2.0",
method: "notifications/message",
params: {
level,
logger: "stdio",
data: {
message,
webAppTransport
.send({
jsonrpc: "2.0",
method: "notifications/message",
params: {
level,
logger: "stdio",
data: {
message,
},
},
},
});
})
.catch(() => {});
}
});

Expand Down Expand Up @@ -707,7 +712,6 @@ app.get(
const endpoint = `${prefix}/message`;

const webAppTransport = new SSEServerTransport(endpoint, res);
webAppTransports.set(webAppTransport.sessionId, webAppTransport);
console.log("Created client transport");

serverTransports.set(webAppTransport.sessionId, serverTransport!); // eslint-disable-line @typescript-eslint/no-non-null-assertion
Expand All @@ -718,6 +722,8 @@ app.get(

await webAppTransport.start();

webAppTransports.set(webAppTransport.sessionId, webAppTransport);

mcpProxy({
transportToClient: webAppTransport,
transportToServer: serverTransport,
Expand Down