fix: skip tool output validation on error #1045
Closed
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a tool returns an error, the output is not guaranteed to conform to the output schema. This change skips the output schema validation when the tool result is an error, preventing incorrect validation errors from being shown.
Type of Change
Changes Made
ToolResults.tsx, added a check to skip output schema validation if the tool result is an error.ToolsTab.test.tsxto ensure that output validation is skipped for error results.Related Issues
Testing
Test Results and/or Instructions
The new test case in
ToolsTab.test.tsxcovers the changes.Checklist
npm run prettier-fix)Breaking Changes
None.
Additional Context
Failure case: