Skip to content

Conversation

@cliffhall
Copy link
Member

Description

In App.samplingNavigation.test.tsx,

  • replaced test for Reject button with the one used in the regular sampling test, which gets the button by role.

Summary

This test isn't failing on main but did fail in the action for a release.

The failure appears to be because formatting puts the name between the button elements with some whitespace. The way the regular sampling test checks is with a regex. No idea why it would fail intermittently, but the previous approach has never failed.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Refactoring (no functional changes)
  • Test updates
  • Build/CI improvements

Testing

  • Tested in UI mode
  • Tested in CLI mode
  • Tested with STDIO transport
  • Tested with SSE transport
  • Tested with Streamable HTTP transport
  • Added/updated automated tests
  • Manual testing performed

Test Results and/or Instructions

Local results are good, but then again main was not failing. We'll see if it works in the release
Screenshot 2026-01-23 at 10 47 19 AM

Checklist

  • Code follows the style guidelines (ran npm run prettier-fix)
  • Self-review completed
  • Code is commented where necessary
  • Documentation updated (README, comments, etc.)

Breaking Changes

Nope.

  - replaced test for Reject button with the one used in the regular sampling test, which gets the button by role. This test appeared to be failing because formatting puts the name between the button elements with some whitespace. The way to look is with a regex
@cliffhall cliffhall marked this pull request as ready for review January 23, 2026 15:49
@olaservo olaservo enabled auto-merge (squash) January 23, 2026 15:50
@olaservo olaservo merged commit 9f3b4ff into modelcontextprotocol:main Jan 23, 2026
5 checks passed
@cliffhall cliffhall deleted the fix-sampling-test branch January 23, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants