-
Notifications
You must be signed in to change notification settings - Fork 437
mcp: Implement support for SEP-2575 on client side #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2fca1b4
98b2a44
222d145
4beb079
23b804b
113cc9f
85a36ed
aecfae4
69a549f
584f8bf
67233a6
52828cd
ded4e45
aba9529
e931735
f809bb2
6cc84d2
fc5865b
b1a06ba
2e2a116
8b572a6
6f1eba0
ddec24b
22c0c7d
31b343c
38d8b59
9e3da0c
372c6ee
b145443
a0e6114
6724ae9
54dedd1
2618874
3747e9f
4b985de
5292ccb
15e4bc3
1b6fe5c
96cef62
ad296c3
2fb3775
d17b423
854bb42
4cc3aa7
02ce00b
6f1f416
8a38b09
ae219d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ var ( | |
| // ErrUnknown should be used for all non coded errors. | ||
| ErrUnknown = NewError(-32001, "unknown error") | ||
| // ErrServerClosing is returned for calls that arrive while the server is closing. | ||
| ErrServerClosing = NewError(-32004, "server is closing") | ||
| ErrServerClosing = NewError(-32006, "server is closing") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh, that's not nice . SDK claimed error codes which are now also used in the spec. ErrClientClosing = NewError(-32003, "client is closing")will now mean for the server side we can do mcgdebug for returning
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure this is needed. The |
||
| // ErrClientClosing is a dummy error returned for calls initiated while the client is closing. | ||
| ErrClientClosing = NewError(-32003, "client is closing") | ||
|
|
||
|
|
@@ -45,6 +45,8 @@ var ( | |
| // should be returned to the caller to indicate that the specific request is | ||
| // invalid in the current context. | ||
| ErrRejected = NewError(-32005, "rejected by transport") | ||
| // ErrUnsupportedProtocolVersion is returned when a server does not support the protocol version. | ||
| ErrUnsupportedProtocolVersion = NewError(-32004, "unsupported protocol version") | ||
| ) | ||
|
|
||
| const wireVersion = "2.0" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if any server implementation close a connection on their side in case of an unknown method request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it will not pass through this path. The server will send a request from the SSE stream, and the client will respond with a new response that will eventually contain the error. But that will be a new POST Response