Add whitespace validation to arcade server game ID validation #348
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validateGameIdfunction was missing whitespace validation, allowing game IDs with spaces, tabs, or newlines to pass validation. This could lead to URL construction issues and potential injection vectors.Changes:
!/\s/.test(gameId)to reject any whitespace characters in game identifiersArchive.org identifiers should not contain whitespace; this validation ensures malformed IDs are rejected before URL construction.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.