fix(e2e): improve test stability and developer experience #337
+119
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w servers - Add HOST_MASKS for Tool Input/Result panels with dynamic timestamps - Add say-server to SLOW_SERVERS (10s) for TTS model download - Add say-server to EXTRA_WAIT_MS (30s) in generate-grid-screenshots
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
… screenshots - Add hideThemeToggle param to getQueryParams() - Conditionally render ThemeToggle based on ?theme=hide - Update e2e tests to use ?theme=hide for consistent screenshots
ochafik
changed the title
Collaborator
|
@ochafik looks good! (I know this is still a draft) - note that currently (with these fixes) the e2e tests break locally - since the generated image on MacOS don't match the ones that are generated in the CI. Perhaps we need to test e2e locally only with the docker |
Collaborator
|
@ochafik should we merge this so at least the CI will pass? |
liady
approved these changes
Jan 25, 2026
Collaborator
liady
left a comment
liady
left a comment
There was a problem hiding this comment.
this doesnt fix the local dev e2e, but we can merge it so that the CI will pass
idosal
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive improvements to e2e test stability and developer experience.
Changes
E2E Test Stability
HOST_MASKSfor Tool Input/Result panels with timestampssay-server: 10s in tests, 30s in grid screenshots (TTS model download)map-server: 15s (CesiumJS tile loading)waitForAppLoad: 30s (nested iframe loading)?theme=hideparam: Hide theme toggle for consistent screenshotsDeveloper Experience
update-lock:dockerscript: Regenerate package-lock.json with public npm registryCI/CD
update-snapshots.yml- manually trigger snapshot updates via GitHub ActionsBasic Host
?theme=hidequery param: Hide theme toggle buttonhttp://localhost:8080/?theme=hideTesting
All e2e tests passing after snapshot regeneration.