perf(server): skip IdleTrackingBackgroundService timer in stateless mode#1531
Open
MukundaKatta wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
perf(server): skip IdleTrackingBackgroundService timer in stateless mode#1531MukundaKatta wants to merge 2 commits intomodelcontextprotocol:mainfrom
MukundaKatta wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #1515.
IdleTrackingBackgroundServiceruns aPeriodicTimerevery 5 seconds to prune idle sessions and enforceMaxIdleSessionCount. In stateless mode (HttpServerTransportOptions.Stateless = true), theStatefulSessionManageris never populated —StreamableHttpSessionreturns early without storing the session — so there is nothing to prune.Running the timer regardless wastes CPU on every server instance and clutters shutdown paths with a
DisposeAllSessionsAsyncthat has nothing to dispose. With 1.2.0 leaning into stateless-by-default, this is wasted work on most servers.What
BackgroundService.StartAsyncto early-returnTask.CompletedTaskwhen_options.Value.Statelessis true. The timer loop inExecuteAsyncis never started, and theBackgroundService.ExecuteTaskstays null. This was the fix proposed by the issue author and matches the architectural seam exactly: options have been bound by the timeStartAsyncruns, so we don't need to re-plumb DI.Tested
HttpMcpServerBuilderExtensionsTests.cs:IdleTrackingBackgroundService_DoesNotStartTimer_WhenStatelessassertsExecuteTaskis null afterStartAsyncwhenStateless = true.IdleTrackingBackgroundService_StartsTimer_WhenStatefulasserts the inverse for the default stateful mode.IServiceProvider.GetServices<IHostedService>()sinceIdleTrackingBackgroundServiceisinternal sealedand the test project has noInternalsVisibleTo.