Don't treat McpServerHandlers as an independent options type#1313
Merged
Don't treat McpServerHandlers as an independent options type#1313
Conversation
halter73
requested review from
PederHP,
jeffhandley,
mikekistler and
stephentoub
jeffhandley
added
the
breaking-change
jeffhandley
approved these changes
Feb 19, 2026
Collaborator
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
I'm good with this.
jeffhandley
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #1308, I considered whether I should treat
McpServerFilterssimilar toMcpServerHandlersand resolve it usingIOptions<McpServerFilters>in case anyone configured it directly as an options type. Ultimately, I decided against it because it added too much complexity.After more thought, I don't think the complexity makes sense for
McpServerHandlerseither. Having the handler methods on McpServerBuilderExtensions modify theMcpServerOptions.Handlersdirectly seems a lot more straightforward and easier to understand than the previous overwriting logic, so I think we should makeMcpServerOptionsthe source of truth for both handlers and filters before 1.0.