Skip to content

feat(branch-name): allow crowdin branch name [EXP-2523]#135

Merged
philippeauriach merged 2 commits intomasterfrom
feat/allow-crowdin
Aug 7, 2025
Merged

feat(branch-name): allow crowdin branch name [EXP-2523]#135
philippeauriach merged 2 commits intomasterfrom
feat/allow-crowdin

Conversation

@maastrich
Copy link
Copy Markdown
Member

What does it do? Why?

Adds support for crowdin/update-translations branch pattern and refactors regex validation to use .test() method for better performance and readability.

Scope

  • Updates branch name validation regex to include crowdin translation updates
  • Refactors existing regex patterns to use .test() instead of .match() for cleaner code
  • Adds corresponding test cases for the new branch pattern

QA

  • All existing branch patterns continue to work
  • New crowdin pattern is properly validated
  • Invalid crowdin patterns are correctly rejected

Test URL

N/A - Backend validation changes

Copilot AI review requested due to automatic review settings August 7, 2025 08:42
@github-actions github-actions bot added the feat New Feature label Aug 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Crowdin translation update branches by extending branch name validation to accept the crowdin/update-translations pattern. The code is also refactored to use the .test() method instead of .match() for improved performance and readability.

  • Adds validation for crowdin/update-translations branch pattern
  • Refactors regex validation from .match() to .test() method
  • Updates test cases to cover both valid and invalid crowdin branch patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/branch.js Adds crowdin branch validation and refactors regex usage from .match() to .test()
lib/branch.test.js Adds test cases for valid and invalid crowdin branch patterns

Comment thread lib/branch.js
Comment thread lib/branch.js
@philippeauriach philippeauriach merged commit ee6733e into master Aug 7, 2025
26 of 30 checks passed
@philippeauriach philippeauriach deleted the feat/allow-crowdin branch August 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants