Skip to content

feat(branch-name): allow crowdin branch name [EXP-2523]#131

Closed
maastrich wants to merge 2 commits intomasterfrom
feat/allow-crowdin
Closed

feat(branch-name): allow crowdin branch name [EXP-2523]#131
maastrich wants to merge 2 commits intomasterfrom
feat/allow-crowdin

Conversation

@maastrich
Copy link
Copy Markdown
Member

What does it do? Why?

Adds support for crowdin/update-translations branch pattern and refactors regex validation to use .test() method for better performance and readability.

Scope

  • Updates branch name validation regex to include crowdin translation updates
  • Refactors existing regex patterns to use .test() instead of .match() for cleaner code
  • Adds corresponding test cases for the new branch pattern

QA

  • All existing branch patterns continue to work
  • New crowdin pattern is properly validated
  • Invalid crowdin patterns are correctly rejected

Test URL

N/A - Backend validation changes

Copilot AI review requested due to automatic review settings August 7, 2025 08:01
@github-actions github-actions bot added the feat New Feature label Aug 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the crowdin/update-translations branch naming pattern to the branch validation function and refactors the existing regex validation logic to use .test() method instead of .match() for improved performance and readability.

  • Adds validation for crowdin translation update branches with the specific pattern crowdin/update-translations
  • Refactors regex validation from .match() to .test() method for better performance
  • Updates test cases to cover both valid and invalid crowdin branch patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
lib/branch.js Adds crowdin branch pattern validation and refactors regex checks to use .test() method
lib/branch.test.js Adds test cases for valid and invalid crowdin branch patterns

@maastrich maastrich changed the title feat(branch-name): allow crowdin branch name feat(branch-name): allow crowdin branch name [EXP-2523] Aug 7, 2025
Copy link
Copy Markdown
Member

@colinlienard colinlienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je trust

@maastrich maastrich closed this Aug 7, 2025
@maastrich maastrich deleted the feat/allow-crowdin branch August 7, 2025 08:40
@maastrich maastrich restored the feat/allow-crowdin branch August 7, 2025 08:41
@philippeauriach philippeauriach deleted the feat/allow-crowdin branch August 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants