feat(branch-name): allow crowdin branch name [EXP-2523]#131
Closed
feat(branch-name): allow crowdin branch name [EXP-2523]#131
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the crowdin/update-translations branch naming pattern to the branch validation function and refactors the existing regex validation logic to use .test() method instead of .match() for improved performance and readability.
- Adds validation for crowdin translation update branches with the specific pattern
crowdin/update-translations - Refactors regex validation from
.match()to.test()method for better performance - Updates test cases to cover both valid and invalid crowdin branch patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/branch.js | Adds crowdin branch pattern validation and refactors regex checks to use .test() method |
| lib/branch.test.js | Adds test cases for valid and invalid crowdin branch patterns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do? Why?
Adds support for
crowdin/update-translationsbranch pattern and refactors regex validation to use.test()method for better performance and readability.Scope
.test()instead of.match()for cleaner codeQA
Test URL
N/A - Backend validation changes