ENH: Improve report plotting and animate_topomap#13905
Draft
larsoner wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't like how long it takes to generate reports, so I was trying to speed it up a bit. In doing so, I realized
animate_topomapwasn't working properly, and refactored it to reuseplot_evoked_topomapcode. This makes it more feature-complete, and I fixed its behavior (with bothblit=Trueandblit=False). I also made it so the report now hasbutterfly=Truefrom theanimate_topomap, which I think is nice. From this testing code:MWE
You can see it:
I expect some test breakages, will push fixes for those.