-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOC: clarify that min neighbors for clusters is 0 in permutation_clus… #13774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
athishdresu
wants to merge
10
commits into
mne-tools:main
Choose a base branch
from
athishdresu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dda5c4c
DOC: clarify that min neighbors for clusters is 0 in permutation_clus…
athishdresu f8a9bea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a68e8ec
FIX: break long line to pass ruff linting
athishdresu facf42a
FIX: resolve merge conflict and final linting
athishdresu 265d1fc
Merge branch 'main' into main
athishdresu bad37de
MRG: move note to public functions and add changelog
athishdresu de1737f
Merge branch 'main' into main
athishdresu 9cfe0e9
Merge branch 'main' into main
athishdresu 60677d8
DOC: move notes to correct section
athishdresu 12ab11d
Merge branch 'main' of https://github.com/athishdresu/mne-python
athishdresu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Clarify that the default minimum number of neighbors for clusters is 0 in :func:`mne.stats.permutation_cluster_test` and :func:`mne.stats.spatio_temporal_cluster_test`, by `Athish M`_. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1239,6 +1239,10 @@ def permutation_cluster_test( | |
| Notes | ||
| ----- | ||
| %(threshold_clust_f_notes)s | ||
| Note: By default, the minimum number of neighboring | ||
| points (e.g., channels) required to form a cluster is 0. | ||
| This means a single significant point can | ||
| technically constitute a cluster. | ||
|
|
||
| References | ||
| ---------- | ||
|
|
@@ -1539,6 +1543,10 @@ def spatio_temporal_cluster_test( | |
| Notes | ||
| ----- | ||
| %(threshold_clust_f_notes)s | ||
| Note: By default, the minimum number of neighboring | ||
| points (e.g., channels) required to form a cluster is 0. | ||
| This means a single significant point can | ||
| technically constitute a cluster. | ||
|
Comment on lines
+1546
to
+1549
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't put notes in References section. |
||
|
|
||
| References | ||
| ---------- | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this note is in the References section. There's a "Notes" section right above.