Skip to content

Conversation

@tsbinns
Copy link
Contributor

@tsbinns tsbinns commented Feb 9, 2026

Reference issue (if any)

Discussed in #13641

What does this implement/fix?

@larsoner, turns out when the specifiers/markers are being prettified, ' in pyproject.toml becomes " (e.g., 'Darwin' -> "Darwin"). Was enough for the check for changed requirements to be triggered.

Just added the conversion of any double back to single quotation marks.

@tsbinns tsbinns changed the title Speczero_fix Fix changelog diff for dependency specifier updates Feb 9, 2026
@tsbinns
Copy link
Contributor Author

tsbinns commented Feb 9, 2026

Will deleting that old, incorrect changelog entry mess with anything?

@larsoner
Copy link
Member

larsoner commented Feb 9, 2026

Will deleting that old, incorrect changelog entry mess with anything?

No it should be fine!

@tsbinns
Copy link
Contributor Author

tsbinns commented Feb 9, 2026

Yeah, no diff from the SPEC0 action (as expected), will return it to scheduled running

@larsoner
Copy link
Member

larsoner commented Feb 9, 2026

Great! Will manually merge once CircleCI comes back happy, other than the expected 45 warnings 😓

(FYI in the latest commit message to save some CI cycles you could have pushed with [skip azp] to skip Azure and [skip actions] to skip GHA since your changes shouldn't affect any of those runs!)

@tsbinns
Copy link
Contributor Author

tsbinns commented Feb 9, 2026

(FYI in the latest commit message to save some CI cycles you could have pushed with [skip azp] to skip Azure and [skip actions] to skip GHA since your changes shouldn't affect any of those runs!)

Sure, I'll keep that in mind for these types of things! Is [ci skip] then an alias for Azure and GHA skipping?

@larsoner
Copy link
Member

larsoner commented Feb 9, 2026

[ci skip] should skip all CIs, i.e., equivalent to [skip circle] [skip azp] [skip actions] (plus maybe also skipping pre-commit.ci, not sure?)

@larsoner
Copy link
Member

larsoner commented Feb 9, 2026

Great!
image

@larsoner larsoner merged commit 87d1051 into mne-tools:main Feb 9, 2026
22 of 30 checks passed
@larsoner
Copy link
Member

larsoner commented Feb 9, 2026

workflow_dispatched in https://github.com/mne-tools/mne-python/actions/runs/21837178549/job/63011327339 and all good, thanks @tsbinns 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants