-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix changelog diff for dependency specifier updates #13645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Will deleting that old, incorrect changelog entry mess with anything? |
No it should be fine! |
|
Yeah, no diff from the SPEC0 action (as expected), will return it to scheduled running |
|
Great! Will manually merge once CircleCI comes back happy, other than the expected 45 warnings 😓 (FYI in the latest commit message to save some CI cycles you could have pushed with |
Sure, I'll keep that in mind for these types of things! Is |
|
|
|
|

Reference issue (if any)
Discussed in #13641
What does this implement/fix?
@larsoner, turns out when the specifiers/markers are being prettified,
'in pyproject.toml becomes"(e.g.,'Darwin'->"Darwin"). Was enough for the check for changed requirements to be triggered.Just added the conversion of any double back to single quotation marks.